Compilation error (SVN r12537)

[WillemS]

I just updated from the SVN repository to revision 12537, and now compilation fails for me (Linux Kubuntu, 32-bit) with the following output:

{l Code}: {l Select All Code}

[ 61%] Building CXX object CMakeFiles/supertuxkart.dir/src/karts/controller/player_controller.cpp.o
/home/willem/SuperTuxKart/stk/src/karts/controller/player_controller.cpp: In memberfunctie ‘virtual void PlayerController::update(float)’:
/home/willem/SuperTuxKart/stk/src/karts/controller/player_controller.cpp:313:9: fout: ‘Log’ has not been declared
make[2]: *** [CMakeFiles/supertuxkart.dir/src/karts/controller/player_controller.cpp.o] Fout 1
make[1]: *** [CMakeFiles/supertuxkart.dir/all] Fout 2
make: *** [all] Fout 2


(the complete compilation output is attached).

It seems that the problematic line (player_controller.cpp:313) is added in revision 12531:

{l Code}: {l Select All Code}

        Log::debug("irr_driver", "-------------------------------------\n");

Is this just my problem, or do others experience the same?

[Funto]

Seems you have to add #include "utils/log.hpp" to player_controller.cpp.
I can't do it now as I can't test it.

BTW, hiker, on that logging functionality: couldn't you make a macro that used __FILE__ / __LINE__ instead of having to always write where the message comes from?
And I still totally dislike the error-prone printf-style formatting ^^.

[WillemS]

Seems you have to add #include "utils/log.hpp" to player_controller.cpp.

That fixes it indeed thank you!

[hiker]

That fixes it indeed thank you!

I fixed that in r12538 - thanks for the report. Strangely enough r12537 compiled fine for me on windows and linux.

Cheers,
Joerg