Weird, but funny admin/auth messages mod

[ClassyRain]

I just thought it would be kinda funny if I added messages that came on auth/admin/setmaster:

src/game/auth.h

{l Code}: {l Select All Code}

    void setmaster(clientinfo *ci, bool val, int flags = 0, bool authed = false)
    {
        int privilege = ci->privilege;
        if(val)
        {
            if(ci->privilege >= flags) return;
            privilege = ci->privilege = flags;
            if(authed)
            {
                if(ci->privilege > PRIV_USER) {
                  srvoutf( -2, "%s has just entered the TWILIGHT ZONE!! MUAHAHAHA!!!  Please respect the rights of the commoners.", colorname(ci) ) ;
                  srvoutf(-2, "\fy%s authenticated as \fs\fc%s\fS and claimed \fs\fc%s\fS", colorname(ci), ci->authname, privname(privilege)); }
                else {
                  srvoutf( -2, "\frWhat's the point of having an auth key if you can't really do anything with it?\fS" );
                  srvoutf(-2, "\fy%s identified as \fs\fc%s\fS", colorname(ci), ci->authname); }
            }
            else {
              srvoutf( -2, "\fzry%s, with power comes responsibility.  Please don't abuse it.  Don't go against the majority.", colorname(ci) );
              srvoutf(-2, "\fy%s claimed \fs\fc%s\fS", colorname(ci), privname(privilege)); }
        }
        else
        {
            if(!ci->privilege) return;
            ci->privilege = PRIV_NONE;
            int others = 0;
            loopv(clients) if(clients[i]->privilege >= PRIV_MASTER || clients[i]->local) others++;
            if(!others) mastermode = MM_OPEN;
            srvoutf(-2, "\fy%s relinquished \fs\fc%s\fS", colorname(ci), privname(privilege));
        }
        masterupdate = true;
        if(paused)
        {
            int others = 0;
            loopv(clients) if(clients[i]->privilege >= (GAME(varslock) >= 2 ? PRIV_ADMIN : PRIV_MASTER) || clients[i]->local) others++;
            if(!others) setpause(false);
        }
    }

What it looks like: (An auth user was not available for the demonstration, sadly)


I just thought it would be slightly amusing

EDIT: ph-[GPL] kindly joined me on my server today. here's a screenshot

[TheLastProject]

There's one issue with the message: the auth users won't be able to see it as it is displayed before they join, just like the "authenticated as" message. Besides that, I would prefer more... "professional" messages, though I am glad that most of your messages are about how auth users should not abuse their power.

I guess this basic idea could also be used to make it more clear for users that Auth User X is a global moderator, as "has authenticated as X and claimed master" is quite confusing for most users.

Good work ecube

[qreeves]

I guess this basic idea could also be used to make it more clear for users that Auth User X is a global moderator, as "has authenticated as X and claimed master" is quite confusing for most users.

This will be addressed in the next release.

I will say this now so there is no confusion: Please don't mess with the auth system at all; if I start allowing even small things like this now, people will start assuming it is okay to make more extreme modifications. Auth is one system I am extremely protective about, as it is our way of protecting the integrity of the game, and I am generally very liberal with modifications to other areas of the game. You don't need to be telling people how to act as a moderator because I have this talk with them when I issue them a key; they are well aware of their rights and responsibilities.

[ClassyRain]

Please don't mess with the auth system at all;

Does that mean it is not okay do this with the authentication messages?

You don't need to be telling people how to act as a moderator because I have this talk with them when I issue them a key; they are well aware of their rights and responsibilities.

Besides that, I would prefer more... "professional" messages

I know, I only put it in for no reason but to make it a bit more lively. Maybe I should just put "Don't make him mad because he can ban you."

[TheLastProject]

Please don't mess with the auth system at all;

Does that mean it is not okay do this with the authentication messages?

Yes, that's what he meant.

[ClassyRain]

Okay. Is everything else tolerated? (Informative join msg, server messages, hi message)

[qreeves]

Okay. Is everything else tolerated? (Informative join msg, server messages, hi message)

Assuming it is non-invasive and doesn't annoy the crap out of people, I'll probably allow it. If you're going to be listing modded servers on the master server then you will probably want to get me to review your changes before going live; I don't mind mods, but you need to understand that you're modifying our game and we have the right to ensure players aren't going to be confused or alarmed or harmed by your changes.

[Fallen]

In my opinion there should be filter in cłient enabling and disabling showing modded servers in server browser.
Btw. Option to auto-download mods will be great, but I know that's can take too many time...

[ClassyRain]

In my opinion there should be filter in cłient enabling and disabling showing modded servers in server browser.
Btw. Option to auto-download mods will be great, but I know that's can take too many time...

This isn't a mod that you 'download'; it happens on the server.

Okay. Is everything else tolerated? (Informative join msg, server messages, hi message)

Assuming it is non-invasive and doesn't annoy the crap out of people, I'll probably allow it. If you're going to be listing modded servers on the master server then you will probably want to get me to review your changes before going live; I don't mind mods, but you need to understand that you're modifying our game and we have the right to ensure players aren't going to be confused or alarmed or harmed by your changes.

Thanks, I'll make sure that doesn't happen (I probably don't need to as I am too unskilled to do much more than print server messages).

[qreeves]

No problem