Page 1 of 1

Key collectable patch

PostPosted: 25 Apr 2012, 15:06
by davy
Hello, I am submiting my key collectable patch. It's as it sounds, I added a key block into the game and to advance to the other level you would need to collect all of the keys.

Along the "collectable.patch" file I added a "data" folder which contains the images of the key. Just throw it in you "meandmyshadow" directory.
To add the key block just use the Level Editor.

UPDATED:

    Fixed the key count reset on play record.
    Modified the key and added 3 different versions of it (for some option). The keys were modified by "ctdabomb".

    Added another patch to the rar file which is attached to this post, it is the same except it makes the player to pick up the key automatically.

Re: Key collectable patch

PostPosted: 25 Apr 2012, 15:26
by Edward_Lii
Hello davy,

davy {l Wrote}:Hello, I am submiting my key collectable patch. It's as it sounds, I added a key block into the game and to advance to the other level you would need to collect all of the keys.

Along the "collectable.patch" file I added a "data" folder which contains the images of the key. Just throw it in you "meandmyshadow" directory.
To add the key block just use the Level Editor.

Thanks for your work, I still need to look at the code closely. ;)

But I think it can be committed in svn soon.

Thanks again for contributing. :)

Re: Key collectable patch

PostPosted: 25 Apr 2012, 16:38
by acme_pjz
Hi davy,

Great work! :D although there are some minor bugs: when the level is finished the game replay will be autoplayed but the key count doesn't get resetted...

Suggestion: maybe the key should be automatic collected without press down key?

Re: Key collectable patch

PostPosted: 25 Apr 2012, 17:48
by davy
Thanks for reporting a bug.

About the suggestion. Maybe it would be better to pick it up without pressing the down key, it wouldn't stop the flow and the key would be something that you have to collect either way to advance to the next level. Thanks for the suggestion :) .

Re: Key collectable patch

PostPosted: 25 Apr 2012, 20:21
by ctdabomb
automatic pickup would be better I think, though down arrow would fit better with the current gameplay....
The key should maybe look a bit different? i was thinking more of something like this:
key.png
key.png (5.2 KiB) Viewed 11041 times

Re: Key collectable patch

PostPosted: 25 Apr 2012, 20:55
by davy
Thanks for a response :) .

About the key. Yeah, it was quickly drawn ^^. Do you mind if I were to use the key image you posted in the future? Credit would be given.

Re: Key collectable patch

PostPosted: 25 Apr 2012, 21:21
by ctdabomb
sure, though it actually came from the keys from Supertux Forest

Re: Key collectable patch

PostPosted: 26 Apr 2012, 13:03
by davy
Well thanks anyway.

Re: Key collectable patch

PostPosted: 26 Apr 2012, 14:09
by ctdabomb
here are three keys, a gold one, a silver, and bronze. they should fit well enough with cloudscape theme, but I don't know what size they should be.......
key-silver.png
key-silver.png (5.9 KiB) Viewed 11017 times
key-gold.png
key-gold.png (6.29 KiB) Viewed 11017 times
key-bronze.png
key-bronze.png (6.21 KiB) Viewed 11017 times

Re: Key collectable patch

PostPosted: 26 Apr 2012, 15:51
by davy
Wow, thanks for the trouble of finding them ;) . Dont worry about the size, I can resize it.

Re: Key collectable patch

PostPosted: 26 Apr 2012, 16:16
by ctdabomb
davy {l Wrote}:Wow, thanks for the trouble of finding them

finding them? :P I made them! :P actually, I modified the supertux keys. they are GPL

Re: Key collectable patch

PostPosted: 26 Apr 2012, 18:58
by davy
Thanks for the replies. Updated the first post.

Re: Key collectable patch

PostPosted: 27 Apr 2012, 10:07
by odamite
Hello everyone,

davy, This is just great! Thank you for contributing with implementing this new awesome feature! Hopefully you've learn something new and useful! :cool:

Only thing that bothers me is the art. I'm not saying it's bad but in my opinion it doesn't quite fit on the Cloudscape theme. For example it isn't pixel art and it has a drop shadow. I would like to see some new graphics... (looking at you Tedium :)) I would also like to see a door at the exit which is closed and then opened when enough keys.

Anyway this feature is pretty much coded now and other things can be fixed later.

Re: Key collectable patch

PostPosted: 27 Apr 2012, 10:16
by davy
odamite {l Wrote}:Hello everyone,

davy, This is just great! Thank you for contributing with implementing this new awesome feature! Hopefully you've learn something new and useful! :cool:

Only thing that bothers me is the art. I'm not saying it's bad but in my opinion it doesn't quite fit on the Cloudscape theme. For example it isn't pixel art and it has a drop shadow. I would like to see some new graphics... (looking at you Tedium :)) I would also like to see a door at the exit which is closed and then opened when enough keys.

Anyway this feature is pretty much coded now and other things can be fixed later.


Thanks! There's not much I can do on the graphics side. But I was thinking the same "doors open/closed" thing but that would include another image for the doors. Plus I'm thinking of adding some sounds to it. Anyways, gonna work on that some time soon :) .

Re: Key collectable patch

PostPosted: 28 Apr 2012, 11:02
by Edward_Lii
Hello davy,

I've committed your patch to svn.
Thanks for your contribution. :D

Note that a next patch should be made using the latest svn.

Re: Key collectable patch

PostPosted: 28 Apr 2012, 13:37
by davy
Edward_Lii {l Wrote}:Hello davy,

I've committed your patch to svn.
Thanks for your contribution. :D

Note that a next patch should be made using the latest svn.


This patch was made using the latest svn too. At first I was using the stable release but then moved to the latest svn :) . I hope there wans't anything wrong with this patch regarding the version of svn.

Re: Key collectable patch

PostPosted: 28 Apr 2012, 13:45
by Edward_Lii
Hello davy,

davy {l Wrote}:This patch was made using the latest svn too. At first I was using the stable release but then moved to the latest svn :) . I hope there wans't anything wrong with this patch regarding the version of svn.

Oh sorry, I now see that my last sentence can be interpreted in two ways.

I didn't mean that your patch wasn't made against the latest svn.
What I meant to say was that the next patch you make shouldn't contain the collectable changes as diff(erence).

Hope it's clear now. :)

Re: Key collectable patch

PostPosted: 28 Apr 2012, 14:04
by davy
Oh, you mean that I should only make a patch than contains only the code I wrote. Yeah, I guess it would make a lot more sense than patching everything so I would risk to overwrite the latest changes and such. :)