BUG: No replay button for the first level

BUG: No replay button for the first level

Postby Tedium » 02 Apr 2012, 18:27

The replay button (background and icon) of the first level of a levelpack doesn't appear when you select it :(.
The actual button still works though.

Replaybug.png
Replaybug.png (54.95 KiB) Viewed 4418 times

As you can see I'm trying out new "inky" icons inspired by odamite's translation mock-ups. See the attachment. Feedback is welcome.
Attachments
recordings.png
recordings.png (260 Bytes) Viewed 4418 times
time.png
time.png (621 Bytes) Viewed 4418 times
User avatar
Tedium
 
Posts: 122
Joined: 19 Oct 2011, 10:40

Re: BUG: No replay button for the first level

Postby ctdabomb » 02 Apr 2012, 18:32

what version?
Some people are like slinkies... not really good for anything, but you still can't help smiling when you shove them down the stairs.
ctdabomb
 
Posts: 1075
Joined: 13 Dec 2011, 21:21
Location: halfway there

Re: BUG: No replay button for the first level

Postby Tedium » 02 Apr 2012, 18:40

0.3-2.4 from the openSUSE repositories.
User avatar
Tedium
 
Posts: 122
Joined: 19 Oct 2011, 10:40

Re: BUG: No replay button for the first level

Postby odamite » 02 Apr 2012, 20:07

Hello Tedium,

I see the bug and I'm not sure what is causing it. And I'm not quite sure what is version 0.3-2.4... :( I'm trying to see what's causing this and I'm sure Edward_Lii can help with it.

I love the new icons and I'm happy that I've been the inspiration for you. It's quite funny because I created the mockups very fast and I was too lazy to find the real icons there. :D But good work and lets see will we start using them.

EDIT: I know what is causing it:
Line 287 (might not be exactly) in LevelPlaySelect.cpp
{l Code}: {l Select All Code}
      if(selectedNumber->getNumber()>0 && selectedNumber->getNumber()<levels.getLevelCount()) {

to
{l Code}: {l Select All Code}
      if(selectedNumber->getNumber()>=0 && selectedNumber->getNumber()<levels.getLevelCount()) {

1 letter changed. Fixed, but I'm not sure can I commit it now or not...
User avatar
odamite
 
Posts: 166
Joined: 16 Jan 2012, 16:28

Re: BUG: No replay button for the first level

Postby Edward_Lii » 03 Apr 2012, 16:14

Hello all,

odamite {l Wrote}:EDIT: I know what is causing it:
Line 287 (might not be exactly) in LevelPlaySelect.cpp
...
1 letter changed. Fixed, but I'm not sure can I commit it now or not...

It's fixed in the latest revision (321), thanks for not committing it. :D
From,
Edward_Lii
User avatar
Edward_Lii
MnMS Moderator
 
Posts: 777
Joined: 20 Dec 2010, 16:46

Who is online

Users browsing this forum: No registered users and 1 guest