GameMap refactoring ideas

[paul424]

The game Map is still the largest file , having 3K LOC.
Any ideas for refactoring that ? One should find out some separate responsibilty or role which could be put into another class. ...

[paul424]

/*! \brief Returns the tiles visible from the given start tile out to the specified sight radius.
*
*/
std::vector<Tile*> GameMap::visibleTiles(Tile *startTile, double sightRadius)
From what I can deduce from the code of it it iterates some ray from the startTile over all tiles in sightRadious. Shouldn't we divide the whole map into convex sectors with visibility map : convex sectors -> list< convex sectors> ? It would be difficult first it would be a dynamic process , second the tunnels or dungeons are not convex hulls nor even polygons ....

[oln]

The GameMap class does too many things right now, so the tasks should probably be split up into separate classes. E.g one keeping track of the tile and entity lists, one doing updates, one containing pathfinding, one doing tile utility functions etc.

As for the visibility calculation, it can probably be improved a lot, but that would be premature optimization, and shouldn't be done at this stage.