Seat color is supposed to be used for teams
![Post Post](./styles/qsilver/imageset/icon_post_target.gif)
I've seen in many parts of the code signs that color is used for defining teams. For example at map write time, where it is pretty clear that seat color is not meant to be unique :
https://github.com/OpenDungeons/OpenDun ... r.cpp#L532
In the actual code, color is used to identify players, which is not the initial expected behaviour. As I am currently fixing the editor (it's almost done), I will remove the quoted part of the code as currently, duplicated color for seats would not work (and in this case, I don't see why we would force players with same color to have the same spawn pool).
But I think we should add a seat parameter ID meant to be unique and used to identify seat/player.
In the actual code, color is checked to allow or not picking up a creature. That would mean 2 allied players could pickup each others creatures. I don't think it is the expected behaviour (at least, not the default one). IMHO, players should only be able to pickup there creatures. Allies should share vision and be able to drop creatures on each others claimed tiles.
Do you agree with this ? If so, I will open an issue on github.
https://github.com/OpenDungeons/OpenDun ... r.cpp#L532
In the actual code, color is used to identify players, which is not the initial expected behaviour. As I am currently fixing the editor (it's almost done), I will remove the quoted part of the code as currently, duplicated color for seats would not work (and in this case, I don't see why we would force players with same color to have the same spawn pool).
But I think we should add a seat parameter ID meant to be unique and used to identify seat/player.
In the actual code, color is checked to allow or not picking up a creature. That would mean 2 allied players could pickup each others creatures. I don't think it is the expected behaviour (at least, not the default one). IMHO, players should only be able to pickup there creatures. Allies should share vision and be able to drop creatures on each others claimed tiles.
Do you agree with this ? If so, I will open an issue on github.