Re: Bubble-Gum
Hi Tuxfan,
you work sounds very nice
unfortunately however I am unable to compile the branch, I come up with this error :
Appears to only be a missing include (#include "utils/log.hpp")
Apart from that, it looks good
I haven't yet had the time to review the code, maybe a fuller code review can be done when the code is close to completion. The only part in your description that I'm not sure about is that two shields would be needed to stop a basketball. We get lots of complaints that basketballs are very difficult to avoid, so I'm not sure that they should require two shields to be stopped. But I guess that's probably easy enough to fix
In addition to making it drop a bubblegum puddle on the floor when done with the shield, I think it would be important now to use some "real" shield model so that visually it's clearer what's going on. If you're in need of a test model, you can use the one I attached. It's not something I would keep in a final state, but will be more helpful than a reset button to visualize and code the shield
PS: If you want to discuss this a bit more, don't hesitate to ask questions, or drop by our IRC channel!
you work sounds very nice
- {l Code}: {l Select All Code}
src/items/rubber_band.cpp:250:13: error: ‘Log’ has not been declared
Appears to only be a missing include (#include "utils/log.hpp")
Apart from that, it looks good
In addition to making it drop a bubblegum puddle on the floor when done with the shield, I think it would be important now to use some "real" shield model so that visually it's clearer what's going on. If you're in need of a test model, you can use the one I attached. It's not something I would keep in a final state, but will be more helpful than a reset button to visualize and code the shield
PS: If you want to discuss this a bit more, don't hesitate to ask questions, or drop by our IRC channel!

