FreeGameDev

Yesterday I noticed small bug in Blackhill Mansion. It was just 5 minutes to fix it, so I did it immediately. But then I spent 30 minutes to make a commit...

The hook script was complaining about missing license for easter_egg.xml, scene.xml, track.xml etc... Do we really need a license for these files? If so, why this is not already available in a global license file? I assume that they should have the same license as whole stk sources? No idea tbh.

It was also complaining about *.spm license. So I just copied the text from License.txt, because I'm not the author of this track and I have no idea about the details of creation process. Which I think wasn't helpful at all.

I think that at least license for exported xml files should be solved globally.

use *.xml

I could modify the script to only check added files, not modified ones.

MTres19 {l Wrote}:I could modify the script to only check added files, not modified ones.

That would be great - files that are modified but not added could probably emit a warning but without blocking

It would be nice indeed. Because I don't know where all these models/textures come from and I would only make a mess.

But still what about the *.xml? Do we really need a license for all these files? If so, can this be added globally i.e. in stk-assets/licenses.txt for all exported xml files? Or artists have to choose which license they prefer?

Well technically they do contain information that could be considered artistic—for example the placement of objects in scene.xml files is definitely an artistic choice and thus would IMO be copyrighted. I'll try to get the script changed today.

Okay, done. Undocumented, freshly added files will block the commit, but undocumented, modified files will just cause the script to emit a warning.