FreeGameDev

I recently did a fresh install of Windows 10. I found that Visual Studio 2019 had just been released, so I downloaded it instead of Visual Studio 2017. It appears to have been compiled in its entirety, but running it is another matter. Note that I'm using the latest windows_64bit dependencies.
Here's the compile log: http://paste.debian.net/1076393/

{l Code}: {l Select All Code}

---------------------------
SuperTuxKart crashed :/
---------------------------
SuperTuxKart crashed!
Please hit Ctrl+C to copy to clipboard and signal the problem
to the developers on our forum: http://forum.freegamedev.net/viewforum.php?f=16

Call stack:

 pngread.c:png_read_destroy:1092
 pngread.c:png_destroy_read_struct:973
 CImageLoaderPNG.cpp:irr::video::CImageLoaderPng::loadImage:249
 sp_texture.cpp:SP::SPTexture::getImageFromPath:137
 sp_texture.cpp:SP::SPTexture::getTextureImage:162
 sp_texture.cpp:SP::SPTexture::threadedLoad:456
 sp_texture_manager.cpp:<lambda_aa8069a420787a7c20c57f5569a1ece0>::operator():67
 thread:std::thread::_Invoke<std::tuple<<lambda_aa8069a420787a7c20c57f5569a1ece0> >,0>:39
 o_exp
 BaseThreadInitThunk
 RtlUserThreadStart
---------------------------
OK   
---------------------------


is it always reproducible?

Yes it is. I get the error both when reopening the exe and when recompiling it.

possible to help debugging it?

Unfortunately, I bumped into a weird problem. I get that crash message when I run a "Release" or "RelWithDebInfo" build, but "Debug" builds run correctly.

Perhaps some compiler optimisation breaks the game... I do not have VS2019 at this time, but I would suggest trying to play with the optimisation level settings, disabling the riskier optimisations and keeping only the simplier optimisations.

Also, anything helpful in the logs? (they are in %appdata%\supertuxkart\config-0.10\stdout.log)

The last shader Supertuxkart attempts to compile is "[info ] ShaderFilesManager: Compiling shader: C:/Users/Danfu/Documents/supertuxkart/stk-code/data/shaders/sp_normal_visualizer.frag"

Aside from that, there doesn't appear to be any useful info in the logs.

Does this patch work for you?

{l Code}: {l Select All Code}

diff --git a/lib/libpng/pngread.c b/lib/libpng/pngread.c
index b90e017e6..ca93ec870 100644
--- a/lib/libpng/pngread.c
+++ b/lib/libpng/pngread.c
@@ -1089,7 +1089,7 @@ png_read_destroy(png_structp png_ptr, png_infop info_ptr,
    free_fn = png_ptr->free_fn;
 #endif
 
-   png_memset(png_ptr, 0, png_sizeof(png_struct));
+   png_memset((png_voidp)png_ptr, 0, png_sizeof(png_struct));
 
    png_ptr->error_fn = error_fn;
 #ifdef PNG_WARNINGS_SUPPORTED


Sorry for taking so long to respond. I can confirm that the problem has been fixed after the patch.

Dunno how VS handle things, but this would be UB if compiled in C++ mode. memset is almost never legal in C++, in fact, I don't know when it is legal in C++.

Illegal memset :-D